RgTools icon indicating copy to clipboard operation
RgTools copied to clipboard

Req: (U)HD version of mode 11

Open Boulder08 opened this issue 4 years ago • 11 comments

For example LSFMod uses Removegrain's mode 11 in its process. However, it's known that the 3x3 kernel is too small for (U)HD resolutions as the actual details in the frame are bigger than single pixels. Having a separate mode with a larger kernel would be very useful for various functions.

https://github.com/realfinder/AVS-Stuff/blob/Community/avs%202.5%20and%20up/LSFmod.avsi

Boulder08 avatar Jun 04 '20 07:06 Boulder08

Removegrain is based strictly on 3x3 kernel so a larger kernel would require writing a completely new filter family, so I'd say no. Probably the logic behind modes cannot be applied straight on a new 5x5 kernel, first you have to establish new rules and formula how a 5x5 matrix defines the new central pixel value. Those new modes should be reinvented and tested for usefulness. From the 28 (?) modes of RgTools only a handful is really good and used.

You can experiment with the kernels using Expr, since it supports relative addressing, you can do such things like "x[-2,-2] x[2,2] min x[-2,2] x[2,-2] min max" etc..

pinterf avatar Jun 04 '20 08:06 pinterf

If I've understood correctly, RemovegrainHD was created to tackle the issue, but source code is probably not available?

Boulder08 avatar Jun 04 '20 08:06 Boulder08

this should has the source code http://chaosking.de/wp-content/uploads/avsfilters/Denoisers/Spatial_Denoisers/RemoveGrainHD___(0.5_-_2011-08-11).7z

but image

realfinder avatar Feb 23 '21 17:02 realfinder

yihaaaa :) You know how I love horrible codes.

pinterf avatar Feb 23 '21 18:02 pinterf

First look: it's not that horrible but a bit hard to read (or I was just get used to the coding style). Note that there were no templates lambdas or constexprs at that time. What's wrong with this plugin, other than it's unmaintainable in its present form?

pinterf avatar Feb 23 '21 19:02 pinterf

it's need new stuff (avs 2.6 Colour formats and HBD)

also maybe it need more modes like classic Removegrain so we can replace the old one with it for HD videos

realfinder avatar Feb 24 '21 04:02 realfinder

This filter is avalilable only for median-based modes, not clear which ones are similar to them in classic removegrain. Required modes then need to be clarified and implemented one by one in the order of importance.

pinterf avatar Feb 24 '21 09:02 pinterf

Not tested at all, algorithm and core unchanged. https://github.com/pinterf/RemoveGrainHD/releases/

pinterf avatar Feb 24 '21 13:02 pinterf

thanks, it's seems work fine from quick test

realfinder avatar Feb 24 '21 18:02 realfinder

Avs 2.6 colorspaces added, and now comes a big silence in the project, it would take weeks to go any further from here.

pinterf avatar Feb 25 '21 08:02 pinterf

thanks, I open discussion about this https://github.com/realfinder/AVS-Stuff/discussions/135

realfinder avatar Mar 04 '21 19:03 realfinder