widgets icon indicating copy to clipboard operation
widgets copied to clipboard

Arbitrary button node structure (deeper than 1 level)

Open max-morawski-photo opened this issue 2 years ago • 1 comments

Simple change to enable share buttons with a structure deeper than 1 level currently supported. My use case is:

<a data-pin-do="buttonBookmark" data-pin-custom="true" ..>
  <div ..>
    <svg ..>
      ..
    </svg>
  </div>
</a>

In this case, click events go to the node and the stock Pinterest code does not work as expected.

max-morawski-photo avatar Jan 15 '23 02:01 max-morawski-photo

Hi, sorry for dead air here. I'm no longer at Pinterest and (since I was the only one monitoring this repo) I doubt a reply will be forthcoming. Your change seems reasonable to me, although I would probably recommend a <span> and not a <div> inside the link, in case we're on an elderly page that needs to pass W3C validation.

kentbrew avatar Feb 10 '23 18:02 kentbrew