teletraan icon indicating copy to clipboard operation
teletraan copied to clipboard

Published 20 hours ago • verified publisher icon pinterest

Google OAUTH2 Support

Open brennentsmith opened this issue 8 years ago • 6 comments

This provides the ability to specify Google’s OAUTH2 service and have Teletraan auth against it. If the option is not explicitly set, the default is to fall back to Pinadmin as the OAUTH2 provider.

Fixed spellings, formatting (quotes), and added SECRET_KEY environment variable to default settings file (since it is a required variable for OAUTH2).

While I have tested this against Google's endpoints, I have not been able to (for obvious reasons) test against pinadmin.

This should help solve questions like: https://github.com/pinterest/teletraan/issues/161

brennentsmith avatar Jun 03 '16 16:06 brennentsmith

Hey! Cool fix! Thanks for the pull request! We're going to take another look at this and experiment with our internal use vs OpenID vs other providers and how we want to handle defining providers and their response formats. Will put a hold on merging this until that is done.

nickdechant avatar Jun 03 '16 18:06 nickdechant

👍 Sounds good to me! Looking forward to see what your team comes up with

brennentsmith avatar Jun 03 '16 19:06 brennentsmith

Moved to a switch rather than conditional blocks for cleanliness and made OpenID the default operation.

brennentsmith avatar Jun 07 '16 20:06 brennentsmith

Hi Teletraan team,

Would you please merge this branch.

ghost avatar Dec 05 '16 17:12 ghost

will double check the fix and update

sbaogang avatar Dec 05 '16 19:12 sbaogang

could you take a look at https://github.com/pinterest/teletraan/pull/285, I believe it handles the openid ( and internal pinterest case ) easier.

sbaogang avatar Dec 07 '16 19:12 sbaogang

Close as PR is too old.

tylerwowen avatar May 28 '24 23:05 tylerwowen