plank icon indicating copy to clipboard operation
plank copied to clipboard

required fields don't do anything in Java

Open shashachu opened this issue 5 years ago • 2 comments

They add @NonNull annotations, but otherwise, there's no consequence. If I have a model with a required field, I'd expect that MyModel.builder().build() would throw an exception, but as it is, it allows you to build a model with null required fields.

shashachu avatar May 29 '19 18:05 shashachu

I think this seems related to the issue around adding validation methods https://github.com/pinterest/plank/issues/185

rahul-malik avatar May 29 '19 18:05 rahul-malik

Haha I'm disagreeing with my past self.

shashachu avatar May 29 '19 18:05 shashachu