it-cpe-cookbooks icon indicating copy to clipboard operation
it-cpe-cookbooks copied to clipboard

Published 20 hours ago • verified publisher icon pinterest

cpe_firewall is not attribute driven on Windows

Open 1dustindavis opened this issue 4 years ago • 5 comments

On Windows, the cpe_firewall cookbook will enable the firewall if it is included in the run list. No attributes need to be set.

At minimum, the windows recipe should only run if node['cpe_firewall']['EnableFirewall'] is true.

1dustindavis avatar Mar 18 '20 16:03 1dustindavis

Ugh. So this is hugely problematic for others using your cookbook. If you have a single run list for all machines, now you will have two behaviors for two different operating systems.

Curious why you didn't make it API driven prior to pushing it.

erikng avatar Mar 18 '20 21:03 erikng

Blame me, @erikng . I'm the one who added the wonky support for Windows. 😛

ChefAustin avatar Mar 18 '20 22:03 ChefAustin

I'll blame Nate. Damnit @natewalck!

erikng avatar Mar 18 '20 22:03 erikng

I didn't make this or even commit code to this. Don't blame me! :D

natewalck avatar Mar 18 '20 22:03 natewalck

I’ll try to fix this tomorrow if the world doesn’t come to and end. Thanks for merging the other PR!

ChefAustin avatar Mar 18 '20 22:03 ChefAustin