gestalt icon indicating copy to clipboard operation
gestalt copied to clipboard

Published 20 hours ago • verified publisher icon pinterest

Docs: Try to add visual-test results to CI

Open rlingineni opened this issue 1 year ago • 9 comments

Pull Request Instructions

Trying to add Visual-test results to CI

Pull Request Template

Summary

What changed?

At a high level, what changes does this PR introduce?

Why?

What is the purpose of this PR? Please include the context around these changes for Future Us. In addition to what is changing, we need to know why these changes are needed. Imagine someone is looking at these changes a year from now and needs to know why they were made.

Links

  • Jira
  • [TDD](link to Paper doc)
  • [Figma](link to Figma file)

Checklist

  • [ ] Added unit and Flow Tests
  • [ ] Added documentation + accessibility tests
  • [ ] Verified accessibility: keyboard & screen reader interaction
  • [ ] Checked dark mode, responsiveness, and right-to-left support
  • [ ] Checked stakeholder feedback (e.g. Gestalt designers, relevant feature teams)

rlingineni avatar Feb 09 '24 20:02 rlingineni

Deploy Preview for gestalt ready!

Name Link
Latest commit b903a9fce83c662cfa80169bd7f16ccd7bef269b
Latest deploy log https://app.netlify.com/sites/gestalt/deploys/65c68effa5db81000843df33
Deploy Preview https://deploy-preview-3419--gestalt.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Feb 09 '24 20:02 netlify[bot]

Deploy Preview for gestalt ready!

Name Link
Latest commit 2b85ee5992888b7bc470eeeefc302b015b762daa
Latest deploy log https://app.netlify.com/sites/gestalt/deploys/65ce4af1b2cc710008bef95b
Deploy Preview https://deploy-preview-3419--gestalt.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Feb 09 '24 20:02 netlify[bot]

Hi from the comments API

rlingineni avatar Feb 15 '24 01:02 rlingineni

Visual test output will be shown!!

rlingineni avatar Feb 15 '24 02:02 rlingineni

Visual test output will be shown!!

rlingineni avatar Feb 15 '24 02:02 rlingineni

Visual test output will be shown!!

rlingineni avatar Feb 15 '24 02:02 rlingineni

Visual test output will be shown!!

rlingineni avatar Feb 15 '24 02:02 rlingineni

Running 160 tests This is an automated visual test report.

Failed Visual Snapshots ❌

These test failures may or may not be related to your changes. These are not blocking. 0 failed visual tests: To see the failed tests, run the following command: yarn run playwright:visual-test test --ui" To update failed tests, run yarn run playwright:visual-test --update-snapshots" Total Test Run Time: 3:18

rlingineni avatar Feb 15 '24 02:02 rlingineni

This is an automated test report Running 160 tests

Failed Visual Snapshots ❌

Note: These test failures may or may not be related to your changes. They are not blocking.

47 failed visual tests:

  • Accordion
  • ActivationCard
  • BannerCallout
  • BannerOverlay
  • BannerSlim
  • BannerUpsell
  • Checkbox
  • Column
  • ComboBox
  • Container
  • Datapoint
  • DateField
  • DatePicker
  • DateRange
  • Dropdown
  • Fieldset
  • Flex
  • Heading
  • HelpButton
  • Label
  • Link
  • List
  • Modal-dark
  • Modal
  • ModalAlert
  • Mobile
  • NumberField
  • PageHeader
  • Pog
  • RadioGroup
  • SearchField
  • SegmentedControl-dark
  • SegmentedControl
  • SelectList
  • Status
  • Switch
  • Table
  • TableOfContents
  • Tabs-dark
  • Tabs
  • Text
  • TextArea
  • TextField
  • TileData
  • Toast
  • WashAnimated
  • ZIndex To see the failed tests, run the following command locally: yarn run playwright:visual-test test --ui

To update failed tests, run yarn run playwright:visual-test --update-snapshots

Total Test Run Time: 3m 19s

rlingineni avatar Feb 15 '24 17:02 rlingineni