gestalt icon indicating copy to clipboard operation
gestalt copied to clipboard

Docs: convert multiple "foundation" page examples to Sandpack

Open christianvuerings opened this issue 2 years ago • 3 comments

Summary

What changed?

  • Converts multiple "foundation" page examples to Sandpack
  • Convert hideControls prop to showControls => makes it consistent with the showEditor prop on SandpackExample
  • Remove t-shirt sizes sm and md from SandpackExample

Why?

For more context see #2221

Flow issues found in this diff:

* Cannot create `Table` element because property `accessibilityLabel` is missing in  props [1] but exists in  `Props` [2].Flow(prop-missing)
* Cannot create `Badge` element because property `inline` is missing in  `Props` [1] but exists in  props [2].Flow(prop-missing)
* Cannot create `Image` element because  string [1] is incompatible with  number [2] in property `naturalWidth`.
* Cannot create `TapArea` element because: Either property `color` is missing in  `TapAreaType` [1] but exists in  props [2]. Or property `color` is missing in  `LinkTapAreaType` [3] but exists in  props [2].Flow(incompatible-type)

christianvuerings avatar Aug 04 '22 15:08 christianvuerings

Deploy Preview for gestalt ready!

Name Link
Latest commit 0ab8f3d9a280a545306ce1beb1337e3725ac1edc
Latest deploy log https://app.netlify.com/sites/gestalt/deploys/62f4aa8e9e03000008a2f254
Deploy Preview https://deploy-preview-2259--gestalt.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] avatar Aug 04 '22 15:08 netlify[bot]

@AlbertCarreras or @dangerismycat could either of you take a look? Would love to merge this asap to avoid further merge conflicts (e.g. gap changes)

christianvuerings avatar Aug 10 '22 13:08 christianvuerings

@christianvuerings Sorry about that — Alberto and Ayesha are out this week, so it's just me. 😅 Taking a look now

dangerismycat avatar Aug 10 '22 22:08 dangerismycat