gestalt icon indicating copy to clipboard operation
gestalt copied to clipboard

React 18 causing Sheet to flash

Open zifahm opened this issue 2 years ago • 3 comments

React 18 flashes sheets

Go to this example in Sheet https://gestalt.netlify.app/sheet#Preventing-close-on-outside-click

Click on View Sheet Then close the Sheet.

Now you can see after closing the sheet a flash of old Sheet, after the sheet gets closed.

This is mostly because of react 18 I presume.

zifahm avatar Jun 15 '22 15:06 zifahm

@zifahm you are correct, the bug is caused by React 18 - PR #2104

Before React 18 we don't see the flash: https://deploy-preview-2103--gestalt.netlify.app/sheet#Preventing-close-on-outside-click After React 18 we do see the flash: https://deploy-preview-2104--gestalt.netlify.app/sheet#Preventing-close-on-outside-click

@ayeshakmaz @AlbertCarreras @dangerismycat have we looked into this bug?

christianvuerings avatar Jul 29 '22 06:07 christianvuerings

Yup I'm still using 17, still havnt migrated.

zifahm avatar Jul 29 '22 06:07 zifahm

@christianvuerings Yes, there's an active bug in our JIRA dashboard for this.

ayeshakmaz avatar Aug 01 '22 23:08 ayeshakmaz