elixir-thrift icon indicating copy to clipboard operation
elixir-thrift copied to clipboard

Support THeader protocol

Open pguillory opened this issue 4 years ago • 2 comments

THeader is an optional wrapper for Thrift RPC messages that allows for requests to include out-of-band headers, useful for things like distributed tracing in service oriented architectures.

This change only implements THeader support on the server side. We can auto-detect the protocol on a per-request basis based on the first two bytes. THeader starts with 0x0FFF, whereas binary starts with 0x8001.

pguillory avatar Nov 14 '21 04:11 pguillory

If the server receives a THeader call, it needs to return a THeader reply, otherwise some clients may break. Generally speaking clients will have a configured a transport/protocol and always use it.

fishcakez avatar Nov 15 '21 16:11 fishcakez

If the server receives a THeader call, it needs to return a THeader reply, otherwise some clients may break. Generally speaking clients will have a configured a transport/protocol and always use it.

Will work on this.

pguillory avatar Nov 15 '21 17:11 pguillory