PINRemoteImage icon indicating copy to clipboard operation
PINRemoteImage copied to clipboard

Fix SPM support

Open woxtu opened this issue 5 years ago • 5 comments

Hi,

The current release installed by SPM can't import headers as follows:

fatal error: 'PINRemoteImage/PINRemoteImage.h' file not found
#import <PINRemoteImage/PINRemoteImage.h>
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

And categories are not loaded:

error: no visible @interface for 'NSImageView' declares the selector 'pin_setImageFromURL:'
[imageView pin_setImageFromURL:[NSURL URLWithString:@"http://pinterest.com/kitten.jpg"]];
 ~~~~~~~~~ ^~~~~~~~~~~~~~~~~~~

This PR contains the following changes to fix that:

  • Put header files back next to source files
  • Create new public headers directory
  • Add missing imports to the framework header

woxtu avatar Nov 19 '20 02:11 woxtu

This does seem to fix the build but it seems to break the categories.

grangej avatar Dec 01 '20 02:12 grangej

@grangej Thank you for your pointing out. I could confirm that categories is not loaded, and maybe the current release has same issue. Anyway I'll fix that.

woxtu avatar Dec 02 '20 03:12 woxtu

Awesome , any chance we can get this merged ??

grangej avatar Dec 12 '20 18:12 grangej

Bump?

mthole avatar Apr 16 '21 17:04 mthole

FYI: This may be taken care of by https://github.com/pinterest/PINRemoteImage/pull/586 already, which is merged to master but not in a release.

mthole avatar Apr 16 '21 17:04 mthole