PINOperation icon indicating copy to clipboard operation
PINOperation copied to clipboard

Published 20 hours ago • verified publisher icon pinterest

Support Carthage xcframework

Open shimastripe opened this issue 2 years ago • 3 comments

WHY

  • Carthage 0.38.0 supports--use-xcframeworks option.
  • XCFramework resolves to Carthage Xcode 12 workaround.

WHAT

  • Fix missing xcode paths in GitHub Actions
    • https://github.com/actions/virtual-environments/blob/main/images/macos/macos-11-Readme.md
    • macOS-latest pre installs Xcode 13.2.1
  • Remove Carthage workaround and use --use-xcframeworks option.

shimastripe avatar May 07 '22 05:05 shimastripe

@garrettmoon This PR supports PINOperation XCFramework. I'd like to continue to support for PINCache / PINRemoteImage. Could you please check it?

shimastripe avatar May 07 '22 07:05 shimastripe

I don't know why the checks didn't run on your PR… Do these changes reflect what you wanted? https://github.com/pinterest/PINOperation/pull/47

garrettmoon avatar Nov 23 '22 00:11 garrettmoon

@garrettmoon It's ok! Thank you. And I commented nits point. https://github.com/pinterest/PINOperation/pull/47#pullrequestreview-1191029482

shimastripe avatar Nov 23 '22 04:11 shimastripe