pinpoint icon indicating copy to clipboard operation
pinpoint copied to clipboard

[#noissue] Ignores exceptions while finding inactive agents

Open smilu97 opened this issue 2 years ago • 1 comments

Traversing all applications to find inactive agents may take tremendous time to query Hbase, and be likely to lose all information in inactiveAgentMap by unavoidable exception on the way.

It logs exceptions while traversing applications, and keeps scope from those.

smilu97 avatar Jul 04 '22 09:07 smilu97

Codecov Report

Merging #9011 (2acd45e) into master (a8c8e20) will decrease coverage by 0.00%. The diff coverage is 71.42%.

@@             Coverage Diff              @@
##             master    #9011      +/-   ##
============================================
- Coverage     39.74%   39.74%   -0.01%     
- Complexity    11794    11797       +3     
============================================
  Files          3347     3347              
  Lines         90823    90827       +4     
  Branches      10053    10053              
============================================
- Hits          36101    36099       -2     
- Misses        51626    51634       +8     
+ Partials       3096     3094       -2     
Impacted Files Coverage Δ
...vercorp/pinpoint/web/service/AdminServiceImpl.java 75.00% <71.42%> (-1.63%) :arrow_down:
...pinpoint/rpc/ChannelWriteFailListenableFuture.java 42.85% <0.00%> (-28.58%) :arrow_down:
...r/context/storage/AsyncQueueingUriStatStorage.java 69.11% <0.00%> (-16.18%) :arrow_down:
...vercorp/pinpoint/rpc/packet/ClientClosePacket.java 46.66% <0.00%> (-6.67%) :arrow_down:
...java/com/navercorp/pinpoint/rpc/DefaultFuture.java 74.31% <0.00%> (-1.84%) :arrow_down:
...orp/pinpoint/rpc/server/DefaultPinpointServer.java 80.65% <0.00%> (-0.42%) :arrow_down:
...vercorp/pinpoint/web/service/AlarmServiceImpl.java 0.00% <0.00%> (ø)
...pinpoint/profiler/monitor/DeadlockMonitorTask.java 21.59% <0.00%> (+1.13%) :arrow_up:
...point/rpc/client/DefaultPinpointClientHandler.java 71.83% <0.00%> (+1.40%) :arrow_up:
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a8c8e20...2acd45e. Read the comment docs.

codecov[bot] avatar Jul 04 '22 10:07 codecov[bot]