pinpoint-plugin-sample icon indicating copy to clipboard operation
pinpoint-plugin-sample copied to clipboard

Sample 2 won't work as expected.

Open joshuaho67 opened this issue 3 years ago • 1 comments

https://github.com/pinpoint-apm/pinpoint-plugin-sample/blob/master/plugin/src/main/java/com/navercorp/pinpoint/plugin/sample/_02_Injecting_Custom_Interceptor/RecordArgsAndReturnValueInterceptor.java line110 wouldn't show arg0 in pinpoint-web since https://github.com/pinpoint-apm/pinpoint-plugin-sample/blob/master/plugin/src/main/resources/META-INF/pinpoint/type-provider.yml line5 it only matches code 998. Do I understand that right?

joshuaho67 avatar Mar 12 '21 03:03 joshuaho67

@jejayhe Modified the sample.

https://github.com/pinpoint-apm/pinpoint-plugin-sample/blob/master/plugins/sample/src/main/java/com/navercorp/pinpoint/plugin/sample/_02_Injecting_Custom_Interceptor/RecordArgsAndReturnValueInterceptor.java

recorder.recordApi(descriptor);
recorder.recordAttribute(SamplePluginConstants.ANNOTATION_KEY_MY_VALUE, arg0);

jaehong-kim avatar Jun 04 '21 01:06 jaehong-kim