pinpoint-kubernetes icon indicating copy to clipboard operation
pinpoint-kubernetes copied to clipboard

add pinpoint-collector

Open JacksChoco opened this issue 4 years ago • 2 comments

  • add pinpoint-collector charts

JacksChoco avatar Sep 27 '20 14:09 JacksChoco

Please resolve the conflict with the latest master branch.

Is 9080 port just for liveness check?

RoySRose avatar Sep 28 '20 07:09 RoySRose

  1. Is port 9080 only for checking liveness?
  2. There was a cleanup on environment variables in the docker image of v2.1.0 Pinpoint. You can see the list under pinpoint-collector in the docker-compose file (https://github.com/naver/pinpoint-docker/blob/master/docker-compose.yml). The differences I found so far are below
  • externalZookeeperAddress can be renamed to something like pinpoint zookeeper address
  • externalHbaseAddress is not necessary
  • I can see Values.externalZookeeperAddress in the values.yaml but where is Values.flink.zookeeperAddress? flink zookeeper address is necessary
  • I don't think Hbase_port is also necessary.

(I think there were a few more things. But can't remember after my former reply was mistakenly deleted. I'll update as soon as I remember)

RoySRose avatar Sep 28 '20 07:09 RoySRose