pino icon indicating copy to clipboard operation
pino copied to clipboard

bindings() and setBindings() are not present in the browser version of pino

Open kirbysayshi opened this issue 4 years ago • 3 comments

Hello!

I was attempting to use pino in the browser today and discovered that .bindings() is undefined. Additionally, .setBindings() is also undefined, but it's also undocumented in general (is it officially part of the API?).

I looked into adding this to browser.js but I'd definitely need some guidance before proceeding. For example, I'm not sure if bindings changes cascade through child loggers or if they are fixed at the time of child creation, for example.

kirbysayshi avatar Oct 20 '21 20:10 kirbysayshi

bindings are fixed at the creation of child loggers

A PR adding this would be awesome!

mcollina avatar Oct 20 '21 20:10 mcollina

@mcollina I'd like to take this up. Any pointers would be awesome

satya-nutella avatar Jan 02 '22 17:01 satya-nutella

The browser.js file is quite readable, take a look!

mcollina avatar Jan 02 '22 17:01 mcollina