pino-arborsculpture icon indicating copy to clipboard operation
pino-arborsculpture copied to clipboard

readFile() leaking

Open benkirk7 opened this issue 3 years ago • 2 comments

This function does not automatically close the file if passed as a fd.

benkirk7 avatar May 10 '21 15:05 benkirk7

Would you like to send a Pull Request to address this issue? Remember to add unit tests.

mcollina avatar May 10 '21 15:05 mcollina

I don't have the time right now putting out fires at work, but the fix is easy... just call fs.close(fd, callback).

benkirk7 avatar May 10 '21 15:05 benkirk7