pinnacle-comp
layout requests are no longer automatic
Describe the bug
layout requests are no longer sent automatically after common operations (non-exhaustive, just what I've noticed):
- toggling/switching tags
- after window creation
they've never been sent after e.g. swapping windows within a layout.
this especially affects GTK applications as they're just not rendered after creation. manually requesting layout from the config cleanly works around the issue.
this workaround is probably fine -- ensuring that the user config requests layout after window layout needs to change isn't onerous. however, the need to do this isn't documented and it's not part of the default config we ship. we should either ensure that a layout request is sent uniformly after all operations that can affect displayed windows or we should update the default config and documentation so users know to request layout after such operations themselves.
Reproduction steps
No response
Relevant parts of config
No response
Version info
commit: 4cc7283046f474450202cbdad1deacfc79392bc8
Distro
NixOS
GPU
No response
Config language
Rust
this especially affects GTK applications as they're just not rendered after creation. manually requesting layout from the config cleanly works around the issue.
I don't observe the same behavior on my end. Can you reproduce the issue with one of the default configs ?
I cannot reproduce this.
they've never been sent after e.g. swapping windows within a layout
They've always been sent, that's how swap is implemented.
we should either ensure that a layout request is sent uniformly after all operations that can affect displayed windows
This should already be happening. I'm not sure why it wouldn't be specifically on your system.
layout requests are no longer sent automatically
In addition to trying to reproduce with the default config as suggested above, can you bisect? I'm not sure why layout requests would stop working. Also, can you post all of your config's layout code? There may be a breaking change that snuck in and you just happened to be using something that got broken.
