sbotools icon indicating copy to clipboard operation
sbotools copied to clipboard

Cannot sboupgrade python3-multidict to 4.7.5 (md5sum failure) (-current)

Open redblade7 opened this issue 5 years ago • 7 comments

Hi,

I can't upgrade python3-multidict to 4.7.5 when using sboupgrade. The file downloads successfully but the verification fails:

--

--2020-03-01 21:17:32-- ftp://slackware.uk/sbosrcarch/by-md5/9/a/9a1ed2cc0cd3e5dd2e71921104f2b760/multidict-4.7.5.tar.gz => ‘multidict-4.7.5.tar.gz’ Resolving slackware.uk (slackware.uk)... 2a02:2498:1:227::240:1, 91.109.244.240 Connecting to slackware.uk (slackware.uk)|2a02:2498:1:227::240:1|:21... connected. Logging in as anonymous ... Logged in! ==> SYST ... done. ==> PWD ... done. ==> TYPE I ... done. ==> CWD (1) /sbosrcarch/by-md5/9/a/9a1ed2cc0cd3e5dd2e71921104f2b760 ... No such directory ‘sbosrcarch/by-md5/9/a/9a1ed2cc0cd3e5dd2e71921104f2b760’.

Unable to download/verify source file(s) for python3-multidict: md5sum failure for /usr/sbo/distfiles/multidict-4.7.5.tar.gz.

Do you want to proceed? [n] Failures: python3-multidict: md5sum failure for /usr/sbo/distfiles/multidict-4.7.5.tar.gz.

--

I filed a bug over at @Ponce's repo and he told me it was an issue with sbotools rather than his repo.

Thank you!

redblade7 avatar Mar 02 '20 18:03 redblade7

Note that I am using -current and set the sbotools repo to Ponce's -current repo, which does not include python3-Cython as -current already uses it. So when prompted about python3-Cython not being in the repo, I just ignore.

redblade7 avatar Mar 02 '20 18:03 redblade7

I don't understand why this is an sbotools problem, I can't even download that URL with wget:

wget "ftp://slackware.uk/sbosrcarch/by-md5/9/a/9a1ed2cc0cd3e5dd2e71921104f2b760/multidict-4.7.5.tar.gz"
--2020-03-02 10:51:08--  ftp://slackware.uk/sbosrcarch/by-md5/9/a/9a1ed2cc0cd3e5dd2e71921104f2b760/multidict-4.7.5.tar.gz
           => ‘multidict-4.7.5.tar.gz’
Resolving slackware.uk... 91.109.244.240, 2a02:2498:1:227::240:1
Connecting to slackware.uk|91.109.244.240|:21... connected.
Logging in as anonymous ... Logged in!
==> SYST ... done.    ==> PWD ... done.
==> TYPE I ... done.  ==> CWD (1) /sbosrcarch/by-md5/9/a/9a1ed2cc0cd3e5dd2e71921104f2b760 ... 
No such directory ‘sbosrcarch/by-md5/9/a/9a1ed2cc0cd3e5dd2e71921104f2b760’.

Your log also shows this failure, the URL doesn't work.

drgibbon avatar Mar 02 '20 18:03 drgibbon

So the responsibility for this lies with the maintainer of python3-multidict then?

redblade7 avatar Mar 02 '20 19:03 redblade7

Looking closer at python3-multidict, the actual URL in the .info file is https://github.com/aio-libs/multidict/archive/v4.7.5/multidict-4.7.5.tar.gz. All that's happening is the md5sum currently in the .info (6ab3fdadc9617a944646033e884b92a0) doesn't match the source from github (which is 9a1ed2cc0cd3e5dd2e71921104f2b760), so sbotools is going looking for the archive elsewhere after the first download fails the md5sum check.

Just ask the maintainer to update the md5sum in the .info, and you can fix it temporarily by updating your local repo.

drgibbon avatar Mar 02 '20 19:03 drgibbon

actually I asked @redblade7 to report this here because what doesn't add up here is that an md5sum error on a source tarball, IMHO, should be handled directly in some way (I never used sbotools so I'm not sure if it actually does already), instead of becoming silently a download error on the mirror site (sbosrcarch).

Ponce avatar Mar 03 '20 17:03 Ponce

I fixed the md5sum in question. https://github.com/isaackwy/slackbuilds/blob/master/Python/python3-multidict/python3-multidict.info

isaackwy avatar Mar 04 '20 00:03 isaackwy

@Ponce Yes perhaps the sboinstall behaviour could be improved somewhat, since the first download failure doesn't give an md5sum error. The full output looks like this:

Install queue: python3-multidict

Are you sure you wish to continue? [y] 
--2020-03-03 21:16:46--  https://github.com/aio-libs/multidict/archive/v4.7.5/multidict-4.7.5.tar.gz
Resolving github.com (github.com)... 192.30.255.112
Connecting to github.com (github.com)|192.30.255.112|:443... connected.
HTTP request sent, awaiting response... 302 Found
Location: https://codeload.github.com/aio-libs/multidict/tar.gz/v4.7.5 [following]
--2020-03-03 21:16:47--  https://codeload.github.com/aio-libs/multidict/tar.gz/v4.7.5
Resolving codeload.github.com (codeload.github.com)... 192.30.255.121
Connecting to codeload.github.com (codeload.github.com)|192.30.255.121|:443... connected.
HTTP request sent, awaiting response... 200 OK
Length: unspecified [application/x-gzip]
Saving to: ‘multidict-4.7.5.tar.gz’

multidict-4.7.5.tar.gz               [ <=>                                                       ]  55.64K  --.-KB/s    in 0.05s   

2020-03-03 21:16:47 (1.14 MB/s) - ‘multidict-4.7.5.tar.gz’ saved [56975]

--2020-03-03 21:16:47--  ftp://slackware.uk/sbosrcarch/by-md5/9/a/9a1ed2cc0cd3e5dd2e71921104f2b760/multidict-4.7.5.tar.gz
           => ‘multidict-4.7.5.tar.gz’
Resolving slackware.uk (slackware.uk)... 91.109.244.240, 2a02:2498:1:227::240:1
Connecting to slackware.uk (slackware.uk)|91.109.244.240|:21... connected.
Logging in as anonymous ... Logged in!
==> SYST ... done.    ==> PWD ... done.
==> TYPE I ... done.  ==> CWD (1) /sbosrcarch/by-md5/9/a/9a1ed2cc0cd3e5dd2e71921104f2b760 ... 
No such directory ‘sbosrcarch/by-md5/9/a/9a1ed2cc0cd3e5dd2e71921104f2b760’.

Unable to download/verify source file(s) for python3-multidict:
  md5sum failure for /usr/sbo/distfiles/multidict-4.7.5.tar.gz.

Do you want to proceed? [n]  

drgibbon avatar Mar 04 '20 05:03 drgibbon