Matthew Zipkin

Network protocol is outdated: headers-first sync, compact blocks, pruned node services

1

1. Message `getBlocks` is no longer used on the network and is likely to be deprecated in the future. 2. Bitcoin Core syncs headers-first. ([since version 0.10](https://github.com/bitcoin/bitcoin/blob/53f26cd11dc04a0ab7a3ee72a3469050c4c2bc17/doc/release-notes/release-notes-0.10.0.md#faster-synchronization)) 3. The behavior...

wallet: double lock when funding

3

Closes https://github.com/bcoin-org/bcoin/issues/906 Copied from the issue discussion... --- So I think I see how a race condition could exist here, and actually it looks like it could happen with `createTX`...

path: remove redundant accountID from path string

5

Fixes https://github.com/bcoin-org/bcoin/issues/484 ~~However, as discussed with @nodar-chkuaselidze in slack, because this string gets written to the db this would break consistency with all keys saved before the change and possibly...

Sync progress % during IBD can be improved: base on # of transactions (not time) since genesis

1

Our progress indicator during sync is a little naive. It's based on the number seconds since the genesis block timestamp: https://github.com/bcoin-org/bcoin/blob/41af3d27a418324493f5258d90605a07350560d9/lib/blockchain/chain.js#L2040-L2045 That means that during sync, you can get a...

### bcoin ``` $ bcoin-cli rpc decodescript 53210242705b9570ec3c193ba67528ff38ee272f37b14ef33564e8d1b33812efb3ad812102bcb81bd3451ed30559473940b58e4272765f272dc17855e1be2b21a05945d23c2102d9f1f9f3214b64b31ef82c16376283e438d738406338776750f86424c2ec303c21036427eda147982560d066449070c457697cf22ff3bbe2d0ecd5ba070d52d9434a21039c6a894d0067c32997f2390c2ecffaa0376ac34c8c0a4ebfa6d738c28814456455ae { "asm": "OP_3 0242705b9570ec3c193ba67528ff38ee272f37b14ef33564e8d1b33812efb3ad81 02bcb81bd3451ed30559473940b58e4272765f272dc17855e1be2b21a05945d23c 02d9f1f9f3214b64b31ef82c16376283e438d738406338776750f86424c2ec303c 036427eda147982560d066449070c457697cf22ff3bbe2d0ecd5ba070d52d9434a 039c6a894d0067c32997f2390c2ecffaa0376ac34c8c0a4ebfa6d738c288144564 OP_5 OP_CHECKMULTISIG", "type": "MULTISIG", "reqSigs": 3, "addresses": [ "2NGERC5oyjs2NY4HMvPFQXazAj6JRZRFnua" ], "p2sh": "2NGERC5oyjs2NY4HMvPFQXazAj6JRZRFnua" } ```...

scripts: fuzz: pass hash as buffer not string

5

One more lingering regression leftover from the great "hashes as buffers instead of strings" refactor from #533

Purpose: to access the hsd data directory used and maintained by Bob, from other compatible wallets like Palm Reader. Problem: `hsd --prefix ~/.config/Bob/hsd_data` also requires `--index-tx` and `--index-address`, not to...

Recevied funds labeled "sent funds"

3

This is the only TX for this wallet, a receipt of 1 HNS, but it is being displayed as the send: This is how Bob is displaying this TX: https://hnsnetwork.com/txs/ff9d471853ecaee83deed16d651e502a3cd546b66ea2fb406515652c59902e69...

verifymessagewithname in SPV is insecure

1

https://github.com/kyokan/bob-wallet/blob/6f3f93bf202740f27cda1b46684d78e94ae68a96/app/background/node/service.js#L491-L514 This is (a) broken because `getNameInfo()` will always return `null` for every name in SPV mode. (`rpc getnameinfo` relies on the Urkel Tree, which in SPV mode is always...

The Shakedex swapProof module expects the nodeClient to be able to `getCoin()`: https://github.com/kurumiimari/shakedex/blob/744387a5e6cf2499e4becc78618babc5bf173e5e/src/swapProof.js#L99-L102 The nodeClient is part of the shakedex `Context` object which only expects the IP address and API...