Matthew Zipkin

Results 673 comments of Matthew Zipkin
trafficstars

> still not merged? Correct. Wanna help?

We could add the speculos feature on top of HID as well, the way it worked with busb is just by changing the `require()` statement. So the speculos.js module might...

Thanks for the review and the bump @Ely68 and for the PR, @poppinlp sorry no one has gotten to review this. I tried running `hs-airdrop` without any changes (master branch)...

Man building on openbsd is hard! Finally installed everything I needed and had to run configure like this: `./configure --with-unbound=/usr/local/ CC=egcc` But then I was able to reproduce your error...

Hm although this now: ``` assertion "sa && dst" failed: file "src/addr.c", line 564, function "hsk_sa_to_string" Abort trap (core dumped) ```

Ok we obviously need to fix that before merging. My guess without digging in is that the original code is correct (it's not a pointer to a struct) and the...

Did you run `hnssec-gen.js`? https://github.com/pinheadmz/handout#2-configure

@IMPranshu @nodech @theanmolsharma thanks so much for your reviews. I addressed all the comments and rebased on master in latest push. Also added a new commit that covers an edge...

Awesome review @nodech and great catch! There was an ugly bug in Rule 2. I also addressed your two other comments by restoring the existing implementations of `hasCoin()` and `isDoubleSpend()`....

> @pinheadmz psbt's still unavailable in bcoin? Yep. this is the unmerged PR right here -- wanna help take it over or review?