vue-local-storage
vue-local-storage copied to clipboard
remove includes in favor of indexOf
picking up where https://github.com/pinguinjkeke/vue-local-storage/pull/37 leaves off
Why polyfill is not an option?
Here are my thoughts:
- Most importantly, clients of your library don't expect to be signing up for a polyfill of
Array.includes
when they install your library. They might have a competing polyfill implementation, or themselves not be polyfilling Array.includes for some reason of their own. - I tend to prefer to do the minimum viable solution. Since this is the only case of using
.includes
in your code base, it feels gratuitous to pull in a polyfill.
What are your thoughts?
:+1: for this PR. Forcing a client to use a polyfill for just one line in a third-party lib is a bit strange.
@pinguinjkeke
@pinguinjkeke
@pinguinjkeke
@pinguinjkeke
I guess I'll just close this