scim2 icon indicating copy to clipboard operation
scim2 copied to clipboard

performance improvement for consecutive client requests:

Open gclayburg opened this issue 5 years ago • 0 comments

create, replace, search

This fix allows the client to reuse the underlying TCP stream and avoid creating a new TCP connection for each request. The effect of this is especially noticeable when the connection to the SCIM server is using TLS or has significant latency.

Ok, I see that ping identity does not accept pull requests, but I suspect that you will want this fix. The performance impact is quite significant under the conditions listed in issue #141

Notes:

  • I have tested this with GET, PUT and POST operations. I have not tried it with PATCH requests, but I suspect there is probably a similar issue there that is not addressed by this PR.
  • After implementing the fix, I noticed that the test class EndpointTestCase will fail in unpredictable ways. However, it seems to me that this is somehow an artifact of how the test is constructed and not an issue with the fix in this PR itself. I can supply the test case I use to verify this if it helps.

Please be aware that Ping Identity does not accept third-party contributions at this time! Please see our contribution guidelines.

Does this close any currently open issues?

… fixes #141

gclayburg avatar Feb 19 '20 20:02 gclayburg