uploadthing icon indicating copy to clipboard operation
uploadthing copied to clipboard

feat: Add `onChange` to `<UploadButton/>` and `<UploadDropzone/>`

Open markflorkowski opened this issue 1 year ago • 7 comments

TODO:

  • Svelte dropzone not accepting files except by drag+drop. Also abort not working (possibly related)

  • Unifies the API between components
  • Marks onDrop as deprecated.

Additional changes:

  • Fixes disabled styling (Discord)
  • Adds/fixes paste functionality on all current FE packages
  • Adds/fixes upload abort functionality on all current packages
  • Tested functionality is equivalent across all current FE packages

image

markflorkowski avatar Jul 12 '24 17:07 markflorkowski

🦋 Changeset detected

Latest commit: cf6337ffc627eaa7278e3315d840810a23d320db

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@uploadthing/react Minor
@uploadthing/solid Minor
@uploadthing/svelte Minor
@uploadthing/vue Minor
@uploadthing/expo Patch
@uploadthing/nuxt Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Jul 12 '24 17:07 changeset-bot[bot]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-uploadthing ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 5, 2024 10:52pm

vercel[bot] avatar Jul 12 '24 17:07 vercel[bot]

📦 Bundle size comparison

Bundle Size (gzip) Visualization
Main 39.85KB See Treemap 📊
PR (25f1a30d3b9eb1ae57d80195eabda1cb3cd469ec) 39.85KB See Treemap 📊
Diff No change

github-actions[bot] avatar Jul 12 '24 17:07 github-actions[bot]

Open in Stackblitz

More templates

@uploadthing/dropzone

pnpm add https://pkg.pr.new/pingdotgg/uploadthing/@uploadthing/dropzone@886
@uploadthing/nuxt

pnpm add https://pkg.pr.new/pingdotgg/uploadthing/@uploadthing/nuxt@886
@uploadthing/react

pnpm add https://pkg.pr.new/pingdotgg/uploadthing/@uploadthing/react@886
@uploadthing/solid

pnpm add https://pkg.pr.new/pingdotgg/uploadthing/@uploadthing/solid@886
@uploadthing/svelte

pnpm add https://pkg.pr.new/pingdotgg/uploadthing/@uploadthing/svelte@886
uploadthing

pnpm add https://pkg.pr.new/pingdotgg/uploadthing@886
@uploadthing/vue

pnpm add https://pkg.pr.new/pingdotgg/uploadthing/@uploadthing/vue@886

commit: cf6337f

pkg-pr-new[bot] avatar Jul 12 '24 21:07 pkg-pr-new[bot]

paste is global right now, is that ok? what if there are 2 dropzones on the page?

iirc there is ref filtering?

juliusmarminge avatar Jul 13 '24 08:07 juliusmarminge

paste is global right now, is that ok? what if there are 2 dropzones on the page?

iirc there is ref filtering?

There is I am just blind 🤦

markflorkowski avatar Jul 13 '24 21:07 markflorkowski

A new canary is available for testing. You can install this latest build in your project with:

pnpm add @uploadthing/[email protected]
pnpm add @uploadthing/[email protected]
pnpm add @uploadthing/[email protected]
pnpm add @uploadthing/[email protected]
pnpm add @uploadthing/[email protected]
pnpm add @uploadthing/[email protected]
pnpm add @uploadthing/[email protected]
pnpm add @uploadthing/[email protected]
pnpm add [email protected]
pnpm add @uploadthing/[email protected]

github-actions[bot] avatar Aug 06 '24 17:08 github-actions[bot]