uploadthing
uploadthing copied to clipboard
pingdotgg
feat: React Native Support
This is an initial prototype of what react native support would look like.
TODO:
- [ ] Fix vercel deployments
- [x] Add theming
- [x] Document props
- [ ] Naming shared pkg
⚠️ No Changeset found
Latest commit: 47511e7c426e576ee60d51f037582f12673b03fa
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
![changeset-bot[bot] avatar](https://avatars.githubusercontent.com/in/28616?v=4 "Published by a pub.dev verified publisher"){kind=small}
The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| docs-uploadthing | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | May 31, 2023 3:24pm |
![vercel[bot] avatar](https://avatars.githubusercontent.com/in/8329?v=4 "Published by a pub.dev verified publisher"){kind=small}
Not sure why the Vercel deployments are failing...
Not sure either, merged main just to be sure it wasn't something that we had already resolved.
Error log doesn't make much sense:
As a side note, I don't think that the full turborepo example should be in this repository. Potentially we are considering moving all of the samples out into template repos (similar to what Clerk does), but at the very least, RN is a weird enough/large enough example that I would prefer it not be in the main development repository.
As a side note, I don't think that the full turborepo example should be in this repository. Potentially we are considering moving all of the samples out into template repos (similar to what Clerk does), but at the very least, RN is a weird enough/large enough example that I would prefer it not be in the main development repository.
Sure, I'll move the create-t3-turbo example into a separate repository for now.
https://github.com/Yash-Singh1/uploadthing-ct3-turbo. It won't work for now because the @uploadthing/react-native package isn't published yet, but the temporary fix would be to use file: in the package.jsons and build the packages locally.
80% sure I fixed the nextra build issue - mind merging main? To handle the pnpm lock conflict, just kill the lockfile and re-run pnpm install
80% sure I fixed the nextra build issue - mind merging main? To handle the pnpm lock conflict, just kill the lockfile and re-run pnpm install
Just realized pnpm automatically handles merge conflicts in lockfiles: https://pnpm.io/git.
@t3dotgg @markflorkowski I can finish up this PR once you think we're ready for React Native support.
@Yash-Singh1 Sorry for the continued delays on this. We really want to make sure that the official recommendations that we make regarding RN are as good as possible and fit into the way that RN devs are used to working.
I really appreciate your effort on this PR, and prompting us to think about this so we can bring the best experience to users of uploadthing.
Would love to get this in on the new community branch before I fork it into a repo
Would love to get this in on the new community branch before I fork it into a repo
Is it in the community branch, I cant seem to find it? Thanks!
Once i started trying to apply patches you lost me haha.
RN can not find uploadthing/server or client module after patches get applied 🤷
No idea what im doing
~~I am working on a recreate of this PR~~, so I will close this one for now.