uploadthing icon indicating copy to clipboard operation
uploadthing copied to clipboard

chore: rename solid helper to `createUploadThing`

Open juliusmarminge opened this issue 10 months ago • 6 comments

Ref: https://github.com/pingdotgg/uploadthing/pull/225#issuecomment-2041461668

Follows createSignal, createEffect, createMemo etc etc, as well as some community libs (createQuery for TanStack Query for example)

juliusmarminge avatar Apr 07 '24 13:04 juliusmarminge

🦋 Changeset detected

Latest commit: 90b380aa35eb47dd1aa2600fc9b9fdbb0f78f107

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@uploadthing/solid Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Apr 07 '24 13:04 changeset-bot[bot]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-uploadthing ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 6, 2024 6:32pm

vercel[bot] avatar Apr 07 '24 13:04 vercel[bot]

Not sure if it matters, but we use createUploadthing() for creating the router on the backend already...

markflorkowski avatar May 29 '24 20:05 markflorkowski

Not sure if it matters, but we use createUploadthing() for creating the router on the backend already...

should be fine, because its only exported in the uploadthing/server package and only imported once in server side code, making any conflicts quite unlikely.

N0tExisting avatar Jun 23 '24 16:06 N0tExisting

making any conflicts quite unlikely.

less concerned about actual code related conflicts, more about it being confusing for users.

markflorkowski avatar Jun 23 '24 19:06 markflorkowski

📦 Bundle size comparison

Bundle Size (gzip) Visualization
Main 39.85KB See Treemap 📊
PR (e2d8e6eb50e543df1b01adc95d46c5d2bcace109) 39.85KB See Treemap 📊
Diff No change

github-actions[bot] avatar Jun 28 '24 20:06 github-actions[bot]