tiup icon indicating copy to clipboard operation
tiup copied to clipboard

tiup list not include tidb-lightning-ctl

Open yilongrong opened this issue 4 years ago • 4 comments

Feature Request

Is your feature request related to a problem? Please describe:

when lightning importer failure,need use lightning ctl to swtich mode bin/tidb-lightning-ctl --switch-mode=normal

Describe the feature you'd like:

Tiup Could include lightning ctl

Describe alternatives you've considered:

Teachability, Documentation, Adoption, Migration Strategy:

https://docs.pingcap.com/zh/tidb/stable/deploy-tidb-lightning

yilongrong avatar Oct 29 '20 09:10 yilongrong

Need to upload tidb-lightning-ctl into mirror's storage

9547 avatar Nov 12 '20 00:11 9547

This should have been fixed by #1863

However lightning seems to be missing:

[dvaneeden@dve-carbon ~]$ tiup install ctl:v6.3.0
download https://tiup-mirrors.pingcap.com/ctl-v6.3.0-linux-amd64.tar.gz 336.02 MiB / 336.02 MiB 100.00% 26.76 MiB/s                                                                                                        
[dvaneeden@dve-carbon ~]$ tiup ctl:v6.3.0 --help
Starting component `ctl`: /home/dvaneeden/.tiup/components/ctl/v6.3.0/ctl --help
TiDB controllers

Usage:
  tiup ctl {tidb/pd/tikv/binlog/etcd/cdc} [flags]

Flags:
  -h, --help             help for tiup
      --ignore-version   Skip explicit version check

If I go to components/ctl and do a go build and then copy the ctl binary to ~/.tiup/components/ctl/v6.3.0/ctl I get this:

$ tiup ctl:v6.3.0 --help
Starting component `ctl`: /home/dvaneeden/.tiup/components/ctl/v6.3.0/ctl --help
TiDB controllers

Usage:
  tiup ctl {tidb/pd/tikv/binlog/etcd/cdc/tidb-lightning} [flags]

Flags:
  -h, --help             help for tiup
      --ignore-version   Skip explicit version check
$ tiup ctl:v6.3.0 tidb-lightning -V
Starting component `ctl`: /home/dvaneeden/.tiup/components/ctl/v6.3.0/ctl tidb-lightning -V
Release Version: v6.3.0
Git Commit Hash: ecd67531f1721d3e49eb15a202ac7c0ae02291ec
Git Branch: heads/refs/tags/v6.3.0
Go Version: go1.19.1
UTC Build Time: 2022-09-23 14:23:33
Race Enabled: false

cc @nexustar

dveeden avatar Oct 05 '22 13:10 dveeden

/type bug

dveeden avatar Oct 05 '22 13:10 dveeden

It seems that just need to update ctl in ctl package

nexustar avatar Oct 08 '22 03:10 nexustar