tiup icon indicating copy to clipboard operation
tiup copied to clipboard

tiup cluster support router service mcs

Open bufferflies opened this issue 1 month ago • 3 comments

What problem does this PR solve?

close #xxx

What is changed and how it works?

Check List

Tests

  • [ ] Unit test
  • [ ] Integration test
  • [ ] Manual test (add detailed scripts or steps below)
  • [ ] No code

Code changes

  • [ ] Has exported function/method change
  • [ ] Has exported variable/fields change
  • [ ] Has interface methods change
  • [ ] Has persistent data change

Side effects

  • [ ] Possible performance regression
  • [ ] Increased code complexity
  • [ ] Breaking backward compatibility

Related changes

  • [ ] Need to cherry-pick to the release branch
  • [ ] Need to update the documentation

Release notes:

NONE

bufferflies avatar Nov 04 '25 13:11 bufferflies

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign bb7133 for approval. For more information see the Code Review Process. Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot[bot] avatar Nov 04 '25 13:11 ti-chi-bot[bot]

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Codecov Report

:x: Patch coverage is 2.99003% with 292 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 36.04%. Comparing base (e525ada) to head (c5ec4fa).

Files with missing lines Patch % Lines
pkg/cluster/spec/router.go 0.00% 172 Missing :warning:
pkg/cluster/api/pdapi.go 0.00% 43 Missing :warning:
components/playground/playground.go 3.85% 23 Missing and 2 partials :warning:
components/playground/instance/pd.go 0.00% 14 Missing :warning:
pkg/cluster/template/scripts/router.go 0.00% 12 Missing :warning:
pkg/cluster/spec/validate.go 0.00% 10 Missing :warning:
pkg/cluster/spec/monitoring.go 0.00% 5 Missing :warning:
pkg/cluster/spec/spec.go 0.00% 4 Missing :warning:
components/playground/main.go 50.00% 3 Missing :warning:
pkg/cluster/template/config/prometheus.go 0.00% 3 Missing :warning:
... and 1 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2636      +/-   ##
==========================================
- Coverage   38.99%   36.04%   -2.95%     
==========================================
  Files         356      330      -26     
  Lines       36898    35998     -900     
==========================================
- Hits        14388    12975    -1413     
- Misses      20709    21189     +480     
- Partials     1801     1834      +33     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov-commenter avatar Dec 12 '25 01:12 codecov-commenter