tiup icon indicating copy to clipboard operation
tiup copied to clipboard

Support router and resource manager services

Open rleungx opened this issue 3 months ago • 2 comments

What problem does this PR solve?

close #xxx

What is changed and how it works?

Check List

Tests

  • [ ] Unit test
  • [ ] Integration test
  • [ ] Manual test (add detailed scripts or steps below)
  • [ ] No code

Code changes

  • [ ] Has exported function/method change
  • [ ] Has exported variable/fields change
  • [ ] Has interface methods change
  • [ ] Has persistent data change

Side effects

  • [ ] Possible performance regression
  • [ ] Increased code complexity
  • [ ] Breaking backward compatibility

Related changes

  • [ ] Need to cherry-pick to the release branch
  • [ ] Need to update the documentation

Release notes:

NONE

rleungx avatar Sep 05 '25 04:09 rleungx

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign xhebox for approval. For more information see the Code Review Process. Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot[bot] avatar Sep 05 '25 04:09 ti-chi-bot[bot]

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 42.17%. Comparing base (e769cc5) to head (aae3a82).

:warning: Current head aae3a82 differs from pull request most recent head e8793bf

Please upload reports for the commit e8793bf to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2600      +/-   ##
==========================================
+ Coverage   40.86%   42.17%   +1.31%     
==========================================
  Files         363      335      -28     
  Lines       37725    36208    -1517     
==========================================
- Hits        15415    15268     -147     
+ Misses      20397    19030    -1367     
+ Partials     1913     1910       -3     
Flag Coverage Δ
tiup 33.88% <ø> (ø)
unittest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov-commenter avatar Sep 05 '25 04:09 codecov-commenter