Remove usql
What problem does this PR solve?
close #2588
What is changed and how it works?
Replaces usql (which brings many indirect dependencies) with printing a line that prints the commandline options for MySQL Client.
This fixes:
- the large number of indirect dependencies of usql
- the usql behaviour not matching the behavior of TiDB docs (as it follows postgres behavior)
tiup clientfor playground having a different behavior and experience as atiup clusteror k8s deployed cluster.
We could:
- Directly call
mysql - Detect what clients (MySQL Client, MySQL Shell, mycli, usql, DBeaver, etc) are installed and print what is applicable
Check List
Tests
- [ ] Unit test
- [ ] Integration test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No code
Code changes
- [ ] Has exported function/method change
- [ ] Has exported variable/fields change
- [ ] Has interface methods change
- [ ] Has persistent data change
Side effects
- [ ] Possible performance regression
- [ ] Increased code complexity
- [ ] Breaking backward compatibility
Related changes
- [ ] Need to cherry-pick to the release branch
- [ ] Need to update the documentation
Release notes:
NONE
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign bb7133 for approval. For more information see the Code Review Process. Please ensure that each of them provides their approval before proceeding.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Codecov Report
:x: Patch coverage is 1.13636% with 87 lines in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 40.60%. Comparing base (e446891) to head (68360f3).
:warning: Report is 5 commits behind head on master.
:warning: Current head 68360f3 differs from pull request most recent head 758d560
Please upload reports for the commit 758d560 to get more accurate results.
Additional details and impacted files
@@ Coverage Diff @@
## master #2596 +/- ##
==========================================
- Coverage 40.97% 40.60% -0.37%
==========================================
Files 363 363
Lines 37683 38216 +533
==========================================
+ Hits 15440 15517 +77
- Misses 20327 20781 +454
- Partials 1916 1918 +2
| Flag | Coverage Δ | |
|---|---|---|
| tiup | 33.89% <ø> (ø) |
|
| unittest | 16.61% <1.14%> (-0.03%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
/cc @xhebox @ottok
@dveeden: GitHub didn't allow me to request PR reviews from the following users: ottok.
Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs.
In response to this:
/cc @xhebox @ottok
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.