tiup icon indicating copy to clipboard operation
tiup copied to clipboard

add tici component in playground

Open kolafish opened this issue 6 months ago • 2 comments

What problem does this PR solve?

close #xxx

What is changed and how it works?

This PR adds TiCI component support to tiup playground with the following improvements:

Key Features

  • Separate TiCIMetaServer and TiCIWorkerNode instances: Each instance runs only one service for better resource management
  • Proper startup sequence: TiDB → TiCDC → TiCI (meta then worker) → TiFlash
  • TiCDC integration: Automatic changefeed creation with configurable S3 sink URI
  • Environment variable support: TICDC_NEWARCH=true for TiCDC startup
  • Unified configuration: Shared binpath and config parameters for both meta and worker instances

Usage

./bin/tiup-playground --pd 1 --kv 1 --db 1 --tiflash 1 \
  --db.binpath ~/Desktop/tidb/bin/tidb-server \
  --tiflash.binpath ~/Desktop/tiflash/cmake-build-debug/dbms/src/Server/tiflash \
  --ticdc 1 --ticdc.binpath ~/Desktop/ticdc/bin/cdc \
  --tici.meta 1 --tici.worker 1 --tici.binpath  ~/Desktop/tici \
  --tag your-cluster-name

Check List

Tests

  • [] Unit test
  • [] Integration test
  • [] Manual test (add detailed scripts or steps below)
  • [] No code

Code changes

  • [] Has exported function/method change
  • [] Has exported variable/fields change
  • [] Has interface methods change
  • [] Has persistent data change

Side effects

  • [] Possible performance regression
  • [] Increased code complexity
  • [] Breaking backward compatibility

Related changes

  • [] Need to cherry-pick to the release branch
  • [] Need to update the documentation

Release notes:

NONE

kolafish avatar Jun 23 '25 13:06 kolafish

CLA assistant check
All committers have signed the CLA.

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 51.91%. Comparing base (7b34205) to head (3d5aefc).

:exclamation: Current head 3d5aefc differs from pull request most recent head 1eabe04

Please upload reports for the commit 1eabe04 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2546      +/-   ##
==========================================
- Coverage   53.81%   51.91%   -1.90%     
==========================================
  Files         351      336      -15     
  Lines       37425    36430     -995     
==========================================
- Hits        20137    18911    -1226     
- Misses      14872    15221     +349     
+ Partials     2416     2298     -118     
Flag Coverage Δ
cluster 39.25% <ø> (-5.61%) :arrow_down:
unittest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov-commenter avatar Jun 25 '25 11:06 codecov-commenter

/cc @xhebox @bb7133

kolafish avatar Jul 16 '25 03:07 kolafish

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign xhebox for approval. For more information see the Code Review Process. Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot[bot] avatar Jul 21 '25 02:07 ti-chi-bot[bot]

[LGTM Timeline notifier]

Timeline:

  • 2025-07-17 08:16:51.227807427 +0000 UTC m=+2765263.950986404: :ballot_box_with_check: agreed by bb7133.
  • 2025-07-21 02:26:51.879319765 +0000 UTC m=+204848.800463755: :heavy_multiplication_x::repeat: reset by xhebox.
  • 2025-07-21 02:27:14.070914586 +0000 UTC m=+204870.992058577: :ballot_box_with_check: agreed by xhebox.

ti-chi-bot[bot] avatar Jul 21 '25 02:07 ti-chi-bot[bot]