tiup icon indicating copy to clipboard operation
tiup copied to clipboard

WIP: Add dependency check to Makefile

Open ottok opened this issue 6 months ago • 1 comments

DRAFT - DO NOT MERGE

Introduce a new check-dependencies target that verifies the presence of required system packages and Go tools on Debian systems. This improves the developer experience by providing clear, actionable feedback if necessary dependencies are missing. Instead of failing with cryptic errors during the build or test phases, the user is informed upfront and given instructions on how to install the missing components.

Additionally, fix goimports execution in fmt target. The $(shell ...) make function is evaluated when the Makefile is first parsed, not when a target is executed. This caused goimports to run every time make was invoked, regardless of the specified target, including for unrelated targets like make clean.

Check List

Tests

  • [x] Manual test (add detailed scripts or steps below)

Side effects

  • [x] Increased code complexity

Release notes:

NONE

ottok avatar Jun 19 '25 17:06 ottok

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign xhebox for approval. For more information see the Code Review Process. Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot[bot] avatar Jun 19 '25 17:06 ti-chi-bot[bot]