tiup icon indicating copy to clipboard operation
tiup copied to clipboard

cluster: improve SELinux compatibility

Open dveeden opened this issue 11 months ago • 3 comments

What problem does this PR solve?

  • Improve SELinux compatibility
  • Fix the context of the systemd files after moving them from /tmp to /etc/systemd

This doesn't change the SELinux policy. We could do that later if we want. So no docs changes for now.

Because of this we don't change the tiup cluster check for SELinux.

What is changed and how it works?

Check List

Tests

Tested:

  • Deploy cluster

  • Start/Stop cluster

  • Manual test (add detailed scripts or steps below)

Release notes:

NONE

dveeden avatar Jan 21 '25 09:01 dveeden

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign xhebox for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot[bot] avatar Jan 21 '25 09:01 ti-chi-bot[bot]

/component cluster

dveeden avatar Jan 21 '25 09:01 dveeden

/label component/cluster

dveeden avatar Jan 21 '25 09:01 dveeden

@dveeden: The label(s) component/cluster cannot be applied. These labels are supported: help wanted, good first issue.

In response to this:

/label component/cluster

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot[bot] avatar Jan 21 '25 09:01 ti-chi-bot[bot]

/cc @breezewish

dveeden avatar Feb 02 '25 11:02 dveeden

[LGTM Timeline notifier]

Timeline:

  • 2025-02-05 02:24:21.585244099 +0000 UTC m=+238533.117656082: :ballot_box_with_check: agreed by breezewish.

ti-chi-bot[bot] avatar Feb 05 '25 02:02 ti-chi-bot[bot]