tiup icon indicating copy to clipboard operation
tiup copied to clipboard

cluster/tiflash: Remove deprecated config items

Open JaySon-Huang opened this issue 1 year ago • 2 comments

What problem does this PR solve?

What is changed and how it works?

  • default_profile/display_name/tmp_path is no longer need since v5.4.0 (https://github.com/pingcap/tiflash/pull/3414)
  • flash.flash_cluster is no longer need since v6.0.0 (https://github.com/pingcap/tidb/issues/29924)

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

NONE

JaySon-Huang avatar Jan 10 '24 06:01 JaySon-Huang

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign kaaaaaaang for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot[bot] avatar Jan 10 '24 06:01 ti-chi-bot[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (3b246a3) 55.43% compared to head (12e12af) 55.39%.

:exclamation: Current head 12e12af differs from pull request most recent head fbe2708. Consider uploading reports for the commit fbe2708 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2357      +/-   ##
==========================================
- Coverage   55.43%   55.39%   -0.05%     
==========================================
  Files         329      329              
  Lines       34841    34848       +7     
==========================================
- Hits        19314    19302      -12     
- Misses      13216    13235      +19     
  Partials     2311     2311              
Flag Coverage Δ
cluster 44.71% <96.55%> (-0.04%) :arrow_down:
dm 25.44% <0.00%> (-0.01%) :arrow_down:
playground 15.37% <0.00%> (+<0.01%) :arrow_up:
tiup 33.59% <ø> (-0.05%) :arrow_down:
unittest 22.36% <100.00%> (+0.01%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Jan 10 '24 06:01 codecov-commenter