tiup icon indicating copy to clipboard operation
tiup copied to clipboard

playground: print version when filling binpath

Open HuSharp opened this issue 1 year ago • 6 comments

What problem does this PR solve?

When filling in the binpath, it isbetter to print out the instance using binpath

What is changed and how it works?

before

$ tiup playground v7.5.0 --pd.binpath /Users/pingcap/CS/PingCAP/pd/bin/pd-server
Start pd instance:v7.5.0
Start tikv instance:v7.5.0
Start tidb instance:v7.5.0

after

$ ./tiup-playground v7.5.0 --pd.binpath /Users/pingcap/pd/bin/pd-server 
Start pd instance:/Users/pingcap/pd/bin/pd-server
Start tikv instance:/Users/pingcap/.tiup/components/tikv/v7.5.0/tikv-server
Start tidb instance:/Users/pingcap/.tiup/components/tidb/v7.5.0/tidb-server

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Release notes:

print version when filling binpath

HuSharp avatar Dec 19 '23 02:12 HuSharp

cc @lhy1024

HuSharp avatar Dec 19 '23 02:12 HuSharp

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 50.91%. Comparing base (342c767) to head (b13c405). Report is 1 commits behind head on master.

:exclamation: Current head b13c405 differs from pull request most recent head af5f9ec

Please upload reports for the commit af5f9ec to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2334      +/-   ##
==========================================
- Coverage   55.22%   50.91%   -4.32%     
==========================================
  Files         334      328       -6     
  Lines       35982    34984     -998     
==========================================
- Hits        19871    17810    -2061     
- Misses      13726    14853    +1127     
+ Partials     2385     2321      -64     
Flag Coverage Δ
tiup 33.59% <ø> (-0.23%) :arrow_down:
unittest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Dec 19 '23 02:12 codecov-commenter

@lhy1024: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ti-chi-bot[bot] avatar Dec 19 '23 04:12 ti-chi-bot[bot]

@nolouch: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ti-chi-bot[bot] avatar Jan 04 '24 10:01 ti-chi-bot[bot]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ti-chi-bot[bot] avatar Jan 05 '24 08:01 ti-chi-bot[bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign kaaaaaaang for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot[bot] avatar Mar 12 '24 10:03 ti-chi-bot[bot]

PTAL, thx! @xhebox

HuSharp avatar Jul 15 '24 03:07 HuSharp

[LGTM Timeline notifier]

Timeline:

  • 2024-07-15 04:20:32.73540351 +0000 UTC m=+241254.726344973: :ballot_box_with_check: agreed by xhebox.

ti-chi-bot[bot] avatar Jul 15 '24 04:07 ti-chi-bot[bot]

/approve

xhebox avatar Jul 15 '24 04:07 xhebox

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xhebox

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot[bot] avatar Jul 15 '24 04:07 ti-chi-bot[bot]