cluster: check vm.min_free_kbytes
What problem does this PR solve?
What is changed and how it works?
Check List
Tests
- Unit test
- Integration test
- Manual test (add detailed scripts or steps below)
- No code
Code changes
- Has exported function/method change
- Has exported variable/fields change
- Has interface methods change
- Has persistent data change
Side effects
- Possible performance regression
- Increased code complexity
- Breaking backward compatibility
Related changes
- Need to cherry-pick to the release branch
- Need to update the documentation
Release notes:
NONE
[REVIEW NOTIFICATION]
This pull request has not been approved.
To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.
The full list of commands accepted by this bot can be found here.
Reviewer can indicate their review by submitting an approval review. Reviewer can cancel approval by submitting a request changes review.
Codecov Report
Attention: 20 lines in your changes are missing coverage. Please review.
Comparison is base (
8fe14ca) 56.24% compared to head (e8bbae6) 45.28%. Report is 100 commits behind head on master.
:exclamation: Current head e8bbae6 differs from pull request most recent head f6f27f8. Consider uploading reports for the commit f6f27f8 to get more accurate results
| Files | Patch % | Lines |
|---|---|---|
| pkg/cluster/operation/check.go | 0.00% | 18 Missing :warning: |
| pkg/cluster/task/check.go | 0.00% | 2 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## master #2179 +/- ##
===========================================
- Coverage 56.24% 45.28% -10.95%
===========================================
Files 318 317 -1
Lines 33452 33457 +5
===========================================
- Hits 18812 15151 -3661
- Misses 12399 16282 +3883
+ Partials 2241 2024 -217
| Flag | Coverage Δ | |
|---|---|---|
| cluster | 36.19% <0.00%> (-8.88%) |
:arrow_down: |
| dm | 26.00% <0.00%> (-0.06%) |
:arrow_down: |
| tiup | 16.01% <ø> (ø) |
|
| unittest | ? |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: srstack Once this PR has been reviewed and has the lgtm label, please assign kaaaaaaang for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
[LGTM Timeline notifier]
Timeline:
2023-08-13 13:27:51.011467668 +0000 UTC m=+464835.560483640: :ballot_box_with_check: agreed by srstack.