pingcap
[TiDB Dashboard] Playground deploys seperated dashboard server by default. Other improvements.
What problem does this PR solve?
What is changed and how it works?
Check List
Tests
- Unit test
- Integration test
- Manual test (add detailed scripts or steps below)
- No code
Code changes
- Has exported function/method change
- Has exported variable/fields change
- Has interface methods change
- Has persistent data change
Side effects
- Possible performance regression
- Increased code complexity
- Breaking backward compatibility
Related changes
- Need to cherry-pick to the release branch
- Need to update the documentation
Release notes:
NONE
[REVIEW NOTIFICATION]
This pull request has not been approved.
To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.
The full list of commands accepted by this bot can be found here.
Reviewer can indicate their review by submitting an approval review. Reviewer can cancel approval by submitting a request changes review.
Codecov Report
Attention: Patch coverage is 0% with 14 lines in your changes are missing coverage. Please review.
Project coverage is 40.02%. Comparing base (
6320e3c) to head (48d02b1). Report is 163 commits behind head on master.
| Files | Patch % | Lines |
|---|---|---|
| pkg/cluster/spec/dashboard.go | 0.00% | 14 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## master #2091 +/- ##
===========================================
- Coverage 56.75% 40.02% -16.73%
===========================================
Files 313 312 -1
Lines 33102 33094 -8
===========================================
- Hits 18784 13244 -5540
- Misses 12091 18037 +5946
+ Partials 2227 1813 -414
| Flag | Coverage Δ | |
|---|---|---|
| cluster | 28.00% <0.00%> (-17.23%) |
:arrow_down: |
| dm | 25.92% <0.00%> (-0.43%) |
:arrow_down: |
| playground | 15.29% <0.00%> (-<0.01%) |
:arrow_down: |
| tiup | 16.54% <0.00%> (-0.03%) |
:arrow_down: |
| unittest | ? |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@SabaPing: PR needs rebase.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.