tiup icon indicating copy to clipboard operation
tiup copied to clipboard

[DNM] cluster: remove tombstone nodes on pd when prune

Open nexustar opened this issue 3 years ago • 3 comments

What problem does this PR solve?

  • close #1969

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

NONE

nexustar avatar Sep 22 '22 04:09 nexustar

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • srstack

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment. After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review. Reviewer can cancel approval by submitting a request changes review.

ti-chi-bot avatar Sep 22 '22 04:09 ti-chi-bot

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 49.20%. Comparing base (901a375) to head (ff025bd). Report is 1 commits behind head on master.

:exclamation: Current head ff025bd differs from pull request most recent head 3e70ac2

Please upload reports for the commit 3e70ac2 to get more accurate results.

:exclamation: There is a different number of reports uploaded between BASE (901a375) and HEAD (ff025bd). Click for more details.

HEAD has 4 uploads less than BASE | Flag | BASE (901a375) | HEAD (ff025bd) | |------|------|------| |tiup|4|1| |cluster|7|6|
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2044      +/-   ##
==========================================
- Coverage   55.03%   49.20%   -5.83%     
==========================================
  Files         334      324      -10     
  Lines       35925    36682     +757     
==========================================
- Hits        19771    18048    -1723     
- Misses      13773    16320    +2547     
+ Partials     2381     2314      -67     
Flag Coverage Δ
cluster 44.21% <100.00%> (-0.06%) :arrow_down:
playground 15.25% <0.00%> (-0.86%) :arrow_down:
tiup 33.50% <ø> (-0.24%) :arrow_down:
unittest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Sep 22 '22 04:09 codecov-commenter

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign kaaaaaaang for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot[bot] avatar Mar 06 '24 02:03 ti-chi-bot[bot]