pingcap
cluster: add support for displaying the grafana URLs in JSON output.
What problem does this PR solve?
close #2040
What is changed and how it works?
Check List
Tests
- Unit test
- Integration test
- Manual test (add detailed scripts or steps below)
- No code
Code changes
- Has exported function/method change
- Has exported variable/fields change
- Has interface methods change
- Has persistent data change
Side effects
- Possible performance regression
- Increased code complexity
- Breaking backward compatibility
Related changes
- Need to cherry-pick to the release branch
- Need to update the documentation
Release notes:
NONE
[REVIEW NOTIFICATION]
This pull request has been approved by:
- AstroProfundis
To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.
The full list of commands accepted by this bot can be found here.
Reviewer can indicate their review by submitting an approval review. Reviewer can cancel approval by submitting a request changes review.
Codecov Report
Base: 47.87% // Head: 46.39% // Decreases project coverage by -1.47% :warning:
Coverage data is based on head (
c3f87be) compared to base (d19f3a2). Patch coverage: 40.00% of modified lines in pull request are covered.
Additional details and impacted files
@@ Coverage Diff @@
## master #2041 +/- ##
==========================================
- Coverage 47.87% 46.39% -1.47%
==========================================
Files 313 313
Lines 36536 37207 +671
==========================================
- Hits 17489 17262 -227
- Misses 16936 17709 +773
- Partials 2111 2236 +125
| Flag | Coverage Δ | |
|---|---|---|
| tiup | 16.17% <ø> (+2.28%) |
:arrow_up: |
| unittest | ? |
Flags with carried forward coverage won't be shown. Click here to find out more.
| Impacted Files | Coverage Δ | |
|---|---|---|
| pkg/cluster/manager/display.go | 49.31% <40.00%> (+2.81%) |
:arrow_up: |
| components/dm/ansible/worker.go | 0.00% <0.00%> (-100.00%) |
:arrow_down: |
| pkg/meta/err.go | 0.00% <0.00%> (-76.19%) |
:arrow_down: |
| pkg/cluster/api/error.go | 0.00% <0.00%> (-75.00%) |
:arrow_down: |
| pkg/crypto/rand/passwd.go | 0.00% <0.00%> (-75.00%) |
:arrow_down: |
| pkg/telemetry/node_info.go | 0.00% <0.00%> (-70.73%) |
:arrow_down: |
| pkg/utils/error.go | 0.00% <0.00%> (-64.29%) |
:arrow_down: |
| components/dm/ansible/import.go | 0.00% <0.00%> (-61.28%) |
:arrow_down: |
| pkg/telemetry/scrub.go | 12.31% <0.00%> (-60.00%) |
:arrow_down: |
| pkg/cluster/executor/local.go | 0.00% <0.00%> (-59.38%) |
:arrow_down: |
| ... and 114 more |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
@onlyacat: GitHub didn't allow me to request PR reviews from the following users: PTAL.
Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs.
In response to this:
/cc @AstroProfundis PTAL
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
I remember only first Grafana is used cc @AstroProfundis
Yes. Only the first Grafana in topology with the literal order is used.
Other Grafana instances should also be accessible but they all use the same datasource which is the first Prometheus in topology with the literal order.
This pull request has been accepted and is ready to merge.