pingcap
pd: set madvdontneed=1 to shrink RSS after GC
Signed-off-by: lhy1024 [email protected]
What problem does this PR solve?
speed up ram gc
What is changed and how it works?
tidb has similar param: https://github.com/pingcap/tiup/blob/master/embed/templates/scripts/run_tidb.sh.tpl
Check List
Release notes:
NONE
[REVIEW NOTIFICATION]
This pull request has been approved by:
- AstroProfundis
To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.
The full list of commands accepted by this bot can be found here.
Reviewer can indicate their review by submitting an approval review. Reviewer can cancel approval by submitting a request changes review.
Codecov Report
Base: 57.19% // Head: 51.85% // Decreases project coverage by -5.34% :warning:
Coverage data is based on head (
2000e8d) compared to base (0599e0d). Patch has no changes to coverable lines.
:exclamation: Current head 2000e8d differs from pull request most recent head 7264518. Consider uploading reports for the commit 7264518 to get more accurate results
Additional details and impacted files
@@ Coverage Diff @@
## master #2019 +/- ##
==========================================
- Coverage 57.19% 51.85% -5.34%
==========================================
Files 313 312 -1
Lines 33513 33502 -11
==========================================
- Hits 19166 17371 -1795
- Misses 12100 13889 +1789
+ Partials 2247 2242 -5
| Flag | Coverage Δ | |
|---|---|---|
| tiup | 16.15% <ø> (ø) |
|
| unittest | ? |
Flags with carried forward coverage won't be shown. Click here to find out more.
| Impacted Files | Coverage Δ | |
|---|---|---|
| components/dm/ansible/worker.go | 0.00% <0.00%> (-100.00%) |
:arrow_down: |
| pkg/meta/err.go | 0.00% <0.00%> (-76.19%) |
:arrow_down: |
| pkg/cluster/api/error.go | 0.00% <0.00%> (-75.00%) |
:arrow_down: |
| pkg/crypto/rand/passwd.go | 0.00% <0.00%> (-75.00%) |
:arrow_down: |
| pkg/telemetry/node_info.go | 0.00% <0.00%> (-70.73%) |
:arrow_down: |
| pkg/utils/error.go | 0.00% <0.00%> (-64.29%) |
:arrow_down: |
| components/dm/ansible/import.go | 0.00% <0.00%> (-61.28%) |
:arrow_down: |
| pkg/telemetry/scrub.go | 12.31% <0.00%> (-60.00%) |
:arrow_down: |
| pkg/cluster/executor/local.go | 0.00% <0.00%> (-59.38%) |
:arrow_down: |
| pkg/cluster/ansible/inventory.go | 0.00% <0.00%> (-58.01%) |
:arrow_down: |
| ... and 43 more |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
@lhy1024 It seems the CI tests are keep failing
There are some logs about this fail. How will I get them?
There are some logs about this fail. How will I get them?
You may try to find them in the assets of Github Actions run. The stdout shows that PD fails to start in certain tests.
There are some logs about this fail. How will I get them?
You may try to find them in the assets of Github Actions run. The stdout shows that PD fails to start in certain tests.
Sorry, I am referring to how should I get the log that appears in the github action, such as /home/tidb/deploy/pd-2379/log, which appears Error: failed to start pd: failed to start: n5 pd-2379.service, please check the instance's log(/home/tidb/ deploy/pd-2379/log) for more detail.: timed out waiting for port 2379 to be started after 2m0s .
Ummm, I reviewed the workflow and seems the log uploading has been broken for long...
Maybe you can try to reproduce that on local server? Just follow the steps in .github/workflows/integrate-cluster-cmd.yaml should be fine.
This pull request has been accepted and is ready to merge.