pingcap
[Draft] cluster: add tidb dashboard
What problem does this PR solve?
What is changed and how it works?
Check List
Tests
- Unit test
- Integration test
- Manual test (add detailed scripts or steps below)
- No code
Code changes
- Has exported function/method change
- Has exported variable/fields change
- Has interface methods change
- Has persistent data change
Side effects
- Possible performance regression
- Increased code complexity
- Breaking backward compatibility
Related changes
- Need to cherry-pick to the release branch
- Need to update the documentation
Release notes:
NONE
[REVIEW NOTIFICATION]
This pull request has been approved by:
- AstroProfundis
To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.
The full list of commands accepted by this bot can be found here.
Reviewer can indicate their review by submitting an approval review. Reviewer can cancel approval by submitting a request changes review.
Codecov Report
Base: 23.46% // Head: 43.71% // Increases project coverage by +20.25% :tada:
Coverage data is based on head (
2828774) compared to base (52b3db5). Patch coverage: 10.32% of modified lines in pull request are covered.
Additional details and impacted files
@@ Coverage Diff @@
## master #2017 +/- ##
===========================================
+ Coverage 23.46% 43.71% +20.25%
===========================================
Files 285 314 +29
Lines 33269 36491 +3222
===========================================
+ Hits 7805 15951 +8146
+ Misses 24593 18643 -5950
- Partials 871 1897 +1026
| Flag | Coverage Δ | |
|---|---|---|
| cluster | 29.56% <8.73%> (?) |
|
| dm | 18.06% <0.00%> (?) |
|
| playground | 12.94% <0.00%> (?) |
|
| tiup | 13.93% <0.00%> (-0.08%) |
:arrow_down: |
| unittest | 20.51% <7.94%> (-0.06%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
| Impacted Files | Coverage Δ | |
|---|---|---|
| pkg/cluster/spec/instance.go | 59.23% <ø> (+41.20%) |
:arrow_up: |
| pkg/cluster/spec/validate.go | 92.97% <ø> (+2.05%) |
:arrow_up: |
| pkg/cluster/template/scripts/dashboard.go | 0.00% <0.00%> (ø) |
|
| pkg/cluster/spec/dashboard.go | 5.32% <5.32%> (ø) |
|
| pkg/cluster/task/update_meta.go | 73.91% <42.86%> (+73.91%) |
:arrow_up: |
| pkg/cluster/spec/spec.go | 79.28% <71.43%> (+28.42%) |
:arrow_up: |
| components/playground/instance/tikv_config.go | 100.00% <0.00%> (ø) |
|
| components/playground/instance/tidb.go | 81.25% <0.00%> (ø) |
|
| components/playground/instance/instance.go | 48.57% <0.00%> (ø) |
|
| components/dm/task/update_dm_meta.go | 0.00% <0.00%> (ø) |
|
| ... and 181 more |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
This pull request has been accepted and is ready to merge.
@nexustar: Your PR was out of date, I have automatically updated it for you.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.