pingcap
cdc check healthy when rolling upgrade
What problem does this PR solve?
What is changed and how it works?
- introduce cdc healthy open api, check for cdc cluster healthy before perform rolling upgrade.
- enable ticdc rolling upgrade since
v6.3.0, which is not public yet.
Check List
Tests
- Manual test (add detailed scripts or steps below)
Code changes
Side effects
Related changes
Release notes:
NONE
[REVIEW NOTIFICATION]
This pull request has been approved by:
- nexustar
To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.
The full list of commands accepted by this bot can be found here.
Reviewer can indicate their review by submitting an approval review. Reviewer can cancel approval by submitting a request changes review.
Codecov Report
Merging #2012 (2d1b07c) into master (43c0158) will decrease coverage by
39.60%. The diff coverage is0.00%.
@@ Coverage Diff @@
## master #2012 +/- ##
===========================================
- Coverage 52.63% 13.03% -39.60%
===========================================
Files 308 162 -146
Lines 35913 20482 -15431
===========================================
- Hits 18900 2668 -16232
- Misses 14793 17395 +2602
+ Partials 2220 419 -1801
| Flag | Coverage Δ | |
|---|---|---|
| cluster | ? |
|
| dm | ? |
|
| playground | 13.03% <0.00%> (-13.07%) |
:arrow_down: |
| tiup | ? |
|
| unittest | ? |
Flags with carried forward coverage won't be shown. Click here to find out more.
| Impacted Files | Coverage Δ | |
|---|---|---|
| pkg/cluster/api/cdcapi.go | 0.00% <0.00%> (-54.12%) |
:arrow_down: |
| pkg/cluster/spec/cdc.go | 0.00% <0.00%> (-61.49%) |
:arrow_down: |
| pkg/tidbver/tidbver.go | 15.79% <0.00%> (-84.21%) |
:arrow_down: |
| embed/embed.go | 0.00% <0.00%> (-100.00%) |
:arrow_down: |
| pkg/meta/paths.go | 0.00% <0.00%> (-100.00%) |
:arrow_down: |
| pkg/repository/store/store.go | 0.00% <0.00%> (-100.00%) |
:arrow_down: |
| pkg/cluster/template/config/config.go | 0.00% <0.00%> (-100.00%) |
:arrow_down: |
| pkg/cluster/template/scripts/scripts.go | 0.00% <0.00%> (-100.00%) |
:arrow_down: |
| pkg/cluster/spec/validate.go | 0.00% <0.00%> (-92.97%) |
:arrow_down: |
| pkg/cluster/spec/bindversion.go | 0.00% <0.00%> (-90.91%) |
:arrow_down: |
| ... and 268 more |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
This pull request has been accepted and is ready to merge.