tiup icon indicating copy to clipboard operation
tiup copied to clipboard

RFC: Separate Component Version in Cluster

Open nexustar opened this issue 3 years ago • 2 comments

What problem does this PR solve?

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

NONE

nexustar avatar Aug 07 '22 08:08 nexustar

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment. After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review. Reviewer can cancel approval by submitting a request changes review.

ti-chi-bot avatar Aug 07 '22 08:08 ti-chi-bot

On TiDB v6.3.0, we will just make TiDB-Dashboard use the same version as TiDB. This RFC will not be implement recently.

nexustar avatar Aug 23 '22 05:08 nexustar

[LGTM Timeline notifier]

Timeline:

  • 2023-08-25 09:36:15.102532553 +0000 UTC m=+1487739.651548538: :ballot_box_with_check: agreed by kaaaaaaang.
  • 2023-08-25 10:32:59.522909404 +0000 UTC m=+1491144.071925388: :heavy_multiplication_x::repeat: reset by kaaaaaaang.
  • 2023-08-25 13:10:16.956991749 +0000 UTC m=+1500581.506007736: :ballot_box_with_check: agreed by kaaaaaaang.
  • 2023-11-17 08:46:39.264507562 +0000 UTC m=+4411596.851617705: :heavy_multiplication_x::repeat: reset by nexustar.

ti-chi-bot[bot] avatar Nov 17 '23 08:11 ti-chi-bot[bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign kaaaaaaang for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot[bot] avatar Nov 17 '23 08:11 ti-chi-bot[bot]

New changes are detected. LGTM label has been removed.

ti-chi-bot[bot] avatar Nov 17 '23 08:11 ti-chi-bot[bot]