tiup
tiup copied to clipboard
fix scale-out check failed with 'no pd found' message
Bug Report
Please answer these questions before submitting your issue. Thanks!
- What did you do?
-
download tiup:curl --proto '=https' --tlsv1.2 -sSf https://tiup-mirrors.pingcap.com/install.sh | sh 2.tiup cluster deploy test v6.1.0 test.yaml 3.tiup cluster check test scale-out.yaml --cluster
-
What did you expect to see? Node Check Result Message xxx.xxx.xxx.xxx timezone True
-
What did you see instead? Node Check Result Message xxx.xxx.xxx.xxx timezone Fail no pd found
-
What version of TiUP are you using (
tiup --version
)? v1.10.2
[REVIEW NOTIFICATION]
This pull request has not been approved.
To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer
in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer
in the comment to help you merge this pull request.
The full list of commands accepted by this bot can be found here.
Reviewer can indicate their review by submitting an approval review. Reviewer can cancel approval by submitting a request changes review.
Codecov Report
Merging #1983 (13b9469) into master (8117e9a) will decrease coverage by
4.27%
. The diff coverage is0.00%
.
:exclamation: Current head 13b9469 differs from pull request most recent head 777d9f7. Consider uploading reports for the commit 777d9f7 to get more accurate results
@@ Coverage Diff @@
## master #1983 +/- ##
==========================================
- Coverage 52.56% 48.29% -4.27%
==========================================
Files 307 307
Lines 35482 35571 +89
==========================================
- Hits 18648 17177 -1471
- Misses 14641 16358 +1717
+ Partials 2193 2036 -157
Flag | Coverage Δ | |
---|---|---|
cluster | 34.95% <0.00%> (-6.19%) |
:arrow_down: |
dm | 24.39% <0.00%> (-0.08%) |
:arrow_down: |
playground | 12.97% <ø> (ø) |
|
tiup | 14.45% <ø> (ø) |
|
unittest | 20.98% <0.00%> (-0.05%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted Files | Coverage Δ | |
---|---|---|
pkg/cluster/manager/check.go | 4.43% <0.00%> (-65.18%) |
:arrow_down: |
pkg/cluster/operation/check.go | 0.00% <0.00%> (-47.42%) |
:arrow_down: |
pkg/cluster/task/builder.go | 86.24% <0.00%> (-13.76%) |
:arrow_down: |
pkg/cluster/task/check.go | 0.00% <0.00%> (-27.78%) |
:arrow_down: |
pkg/cluster/operation/systemd.go | 0.00% <0.00%> (-75.00%) |
:arrow_down: |
pkg/cluster/task/limits.go | 0.00% <0.00%> (-65.22%) |
:arrow_down: |
pkg/cluster/task/sysctl.go | 0.00% <0.00%> (-63.64%) |
:arrow_down: |
pkg/cluster/manager/cleanup.go | 0.00% <0.00%> (-59.13%) |
:arrow_down: |
pkg/cluster/task/copy_file.go | 0.00% <0.00%> (-52.94%) |
:arrow_down: |
... and 50 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 8117e9a...777d9f7. Read the comment docs.
there was a the same problem happend in AskTUG. hopefully fixed it ASAP 🙏,--> https://asktug.com/t/topic/902776
@King-Dylan: PR needs rebase.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
fixed on https://github.com/pingcap/tiup/pull/2045