tiup icon indicating copy to clipboard operation
tiup copied to clipboard

pkg/utils: fix get free port from ipv6 host

Open sleepymole opened this issue 3 years ago • 2 comments

What problem does this PR solve?

tiup playground can not specify an ipv6 host.

What is changed and how it works?

Use the correct function to join host port.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

Fix playground cannot specify ipv6 host

sleepymole avatar Jul 01 '22 08:07 sleepymole

/cc @AstroProfundis

sleepymole avatar Jul 01 '22 09:07 sleepymole

Does TiDB support ipv6 now?

nexustar avatar Aug 04 '22 08:08 nexustar