tiup icon indicating copy to clipboard operation
tiup copied to clipboard

dm: update monitor topo with openapi

Open nexustar opened this issue 3 years ago • 2 comments

What problem does this PR solve?

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

NONE

nexustar avatar Apr 25 '22 11:04 nexustar

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment. After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review. Reviewer can cancel approval by submitting a request changes review.

ti-chi-bot avatar Apr 25 '22 11:04 ti-chi-bot

Codecov Report

Patch coverage: 80.00% and project coverage change: +0.01% :tada:

Comparison is base (fd85680) 52.84% compared to head (c97bf28) 52.85%. Report is 155 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1859      +/-   ##
==========================================
+ Coverage   52.84%   52.85%   +0.01%     
==========================================
  Files         307      308       +1     
  Lines       35175    35256      +81     
==========================================
+ Hits        18585    18633      +48     
- Misses      14404    14430      +26     
- Partials     2186     2193       +7     
Flag Coverage Δ
cluster 41.16% <31.03%> (-0.07%) :arrow_down:
dm 24.74% <76.29%> (+0.17%) :arrow_up:
playground 12.72% <0.00%> (-0.03%) :arrow_down:
tiup 14.33% <0.00%> (-0.01%) :arrow_down:
unittest 21.18% <0.00%> (-0.02%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
components/dm/command/scale_in.go 62.39% <ø> (ø)
pkg/utils/http_client.go 47.68% <55.00%> (+1.12%) :arrow_up:
components/dm/command/reload.go 72.73% <80.00%> (+1.76%) :arrow_up:
components/dm/task/update_dm_topology.go 82.14% <82.14%> (ø)
components/cluster/command/reload.go 76.32% <100.00%> (+1.32%) :arrow_up:
components/dm/command/prune.go 54.17% <100.00%> (ø)
components/dm/command/root.go 56.50% <100.00%> (ø)
components/dm/command/scale_out.go 88.00% <100.00%> (+1.04%) :arrow_up:
components/dm/command/start.go 82.35% <100.00%> (+2.35%) :arrow_up:
pkg/cluster/manager/reload.go 65.26% <100.00%> (-1.74%) :arrow_down:
... and 1 more

... and 6 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Apr 25 '22 11:04 codecov-commenter