tiup icon indicating copy to clipboard operation
tiup copied to clipboard

It' unsafe to replace into patch dir if there are dynamic libraries

Open solotzg opened this issue 3 years ago • 0 comments

Bug Report

If runtime needs dynamic libraries, overwriting binaries by cmd tar directly may cause unexpected behavior.

Like https://github.com/pingcap/tiup/blob/ca49c7e8f57bccc5ff79520d1f5a5481d62364b1/pkg/cluster/task/install_package.go#L50

2 options:

  • Remove target binaries first before installing.
  • Stop services(like tiflash server) before installing.

solotzg avatar Mar 25 '22 06:03 solotzg