tiup icon indicating copy to clipboard operation
tiup copied to clipboard

Make THP check less strict

Open dveeden opened this issue 3 years ago • 1 comments

Bug Report

Currently the THP check checks both /sys/kernel/mm/transparent_hugepage/enabled and /sys/kernel/mm/transparent_hugepage/defrag. To me it looks like having /enabled set to [never] should be sufficient.

This is with tiup v1.8.2

See also https://www.kernel.org/doc/Documentation/vm/transhuge.txt This affects users that set transparent_hugepage=never as boot parameter as suggested in transhuge.txt

dveeden avatar Jan 25 '22 18:01 dveeden

It looks like https://docs.pingcap.com/tidb/stable/check-before-deployment is also not mentioning /defrag in most THP advise, except for one specific location.

dveeden avatar Jan 25 '22 19:01 dveeden