tiup icon indicating copy to clipboard operation
tiup copied to clipboard

tests: add ssh proxy testcases

Open 9547 opened this issue 4 years ago • 4 comments

What problem does this PR solve?

Add more ssh-proxy-based test cases.

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

NONE

9547 avatar Jul 02 '21 14:07 9547

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment. After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review. Reviewer can cancel approval by submitting a request changes review.

ti-chi-bot avatar Jul 02 '21 14:07 ti-chi-bot

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 50.76%. Comparing base (b38df71) to head (61b90f8). Report is 373 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #1470       +/-   ##
===========================================
+ Coverage   15.80%   50.76%   +34.95%     
===========================================
  Files         149      290      +141     
  Lines       15023    26349    +11326     
===========================================
+ Hits         2375    13376    +11001     
+ Misses      12131    10962     -1169     
- Partials      517     2011     +1494     
Flag Coverage Δ
cluster 43.86% <ø> (?)
dm 26.18% <ø> (?)
integrate 50.76% <ø> (+34.95%) :arrow_up:
playground 13.54% <ø> (?)
tiup 15.78% <ø> (-0.02%) :arrow_down:
unittest ∅ <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Oct 25 '21 07:10 codecov-commenter

@9547: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ti-chi-bot avatar Dec 18 '21 14:12 ti-chi-bot

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

:white_check_mark: nexustar
:x: jsvisa
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Apr 04 '23 04:04 CLAassistant