multi tikv, and replication.max-replicas: 1, tiup should skip "evict leader"

[seiya-annie]

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. What did you do? using tiup to upgrade tidb v4.0.11 cluster to v5.0.1, tikv upgrading takes more than 20 minutes. when eplication.max-replicas: 1, should not evict leader, should skip this step.

Upgrading component tikv Evicting 9 leaders from store 10.0.2.189:20160... Still waitting for 9 store leaders to transfer... Still waitting for 9 store leaders to transfer... Still waitting for 9 store leaders to transfer... Still waitting for 9 store leaders to transfer... Still waitting for 9 store leaders to transfer... Still waitting for 9 store leaders to transfer... Still waitting for 9 store leaders to transfer... Still waitting for 9 store leaders to transfer... Still waitting for 9 store leaders to transfer... Still waitting for 9 store leaders to transfer... Still waitting for 9 store leaders to transfer... Still waitting for 9 store leaders to transfer.

2. What did you expect to see?

3. What did you see instead?

tikv evict leader when eplication.max-replicas: 1

4. What version of TiUP are you using (tiup --version)? [root@58a644893144 ~]# tiup --version v1.3.7 tiup Go Version: go1.13 Git Branch: release-1.3 GitHash: 37c95bb [root@58a644893144 ~]# tiup cluster --version Starting component cluster: /root/.tiup/components/cluster/v1.4.0/tiup-cluster --version tiup version 1.4.0 tiup Go Version: go1.16.2 Git Ref: v1.4.0 GitHash: eb335e6ad9d0dc19d1c43db422cd409d62bc3cea [root@58a644893144 ~]#

[xiongjiwei]

met this bug，how can I workaround

tiup --version
1.15.2 tiup
Go Version: go1.21.10
Git Ref: v1.15.2
GitHash: cbcc2ce967981221380a7307bf7843fec2ea5283