tispark
tispark copied to clipboard
Fix TiFlash overflow (#2740)
This is an automated cherry-pick of #2740
What problem does this PR solve?
Reproduce:
create and insert
CREATE TABLE test.t(`a` bigint(20) UNSIGNED NOT NULL)
insert into t values (16717361816800086255)
query from tispark with tiflash returns an error result(negative number)
spark.conf
.set("spark.tispark.isolation_read_engines","tiflash")
spark.sql("select * from tidb_catalog.test.t").show()
What is changed and how it works?
TiSpark requests TiFlash using TypeCHBlock
encode, but forgets to handle the UNSIGNED scenes when decoded.
this pr shows how to decode it corretly
Check List
Tests
- Unit test
- Integration test
- Manual test (add detailed scripts or steps below)
- No code
Code changes
- Has exported function/method change
- Has exported variable/fields change
- Has interface methods change
- Has persistent data change
Side effects
- Possible performance regression
- Increased code complexity
- Breaking backward compatibility
Related changes
- Need to cherry-pick to the release branch
- Need to update the documentation
- Need to update the
tidb-ansible
repository - Need to be included in the release note
/run-all-tests
@shiyuhang0: adding LGTM is restricted to approvers and reviewers in OWNERS files.
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@xuanyu66: adding LGTM is restricted to approvers and reviewers in OWNERS files.
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
/approve
/run-all-tests
/merge
@shiyuhang0: We have migrated to builtin LGTM
and approve
plugins for reviewing.
Please use /approve
when you want approve this pull request.
The changes announcement: LGTM plugin changes
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.
/approve
/merge
@shiyuhang0: We have migrated to builtin LGTM
and approve
plugins for reviewing.
Please use /approve
when you want approve this pull request.
The changes announcement: LGTM plugin changes
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.
/approve
/approve
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: shiyuhang0, xuanyu66
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [shiyuhang0,xuanyu66]
Approvers can indicate their approval by writing /approve
in a comment
Approvers can cancel approval by writing /approve cancel
in a comment